RFR: compile-time guard some UseSharedSpaces-only coding with the INCLUDE_CDS macro - was :RE: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro

David Holmes david.holmes at oracle.com
Tue Aug 1 06:59:47 UTC 2017

Hi Matthias,

Back from a long vacation ...

Baesken, Matthias matthias.baesken at sap.com wrote on Thu Jul 13 
12:18:56 UTC 2017:
>> Thank you for noticing that. Yes, it would be helpful if you can add the #if INCLUDE_CDS for CDS only code. 
>> I can help you integrate the changes after they are reviewed.
> Thanks for your feedback !
> I created a bug :
> https://bugs.openjdk.java.net/browse/JDK-8184323
> and a webrev :
> http://cr.openjdk.java.net/~mbaesken/webrevs/8184323/

For the record it was a deliberate choice to not sprinkle INCLUDE_CDS 
ifdefs all through the shared code. INCLUDE_CDS exists only to support 
the minimal VM for which we wanted to exclude complete subsystems not 
every individual line of code that might relate to an unsupported 
function. The fact UseSharedSpaces is false in the MinimalVM was 
sufficient to guard the remaining logic.


More information about the hotspot-dev mailing list