[10] RFR (XS) 8185900: hotspot build failed with gcc version Red Hat 4.4.7-3

Baesken, Matthias matthias.baesken at sap.com
Tue Aug 8 06:42:06 UTC 2017

> On 8/7/17 5:59 PM, David Holmes wrote:

> On 8/08/2017 1:07 AM, coleen.phillimore at oracle.com<mailto:coleen.phillimore at oracle.com> wrote:


>> This seems fine and I will sponsor this, any other reviewers?  I

>> think it meets trival rules.


> Perhaps. But my concern is that when we make a change to suit an old

> compiler how do we know it won't trigger some new warning in a new

> compiler? We have patches going in to fix gcc 7 at one end, and now

> patches for gcc 4.4.7 at the other, with everything in between. That

> is why we set a minimum supported compiler version. My understanding

> was that flags we use now won't work with such old compilers anyway.


 the check for minimum gcc 4.7  was done a while ago because  the  "-fno-var-tracking-assignments"  gcc  compiler flag was used in the HS makefiles (JvmOverrideFiles.gmk<http://ld8443:8080/source/xref/openjdk-jdk10-hs/hotspot/make/lib/JvmOverrideFiles.gmk> ) and this flag
was not supported  in older gcc versions, for example in  gcc 4.3 .
This was leading to the bad situation that configure was ending successfully but the build was failing (for example on SLES11 with default compiler used ).

Best regards, Matthias

More information about the hotspot-dev mailing list