[RFH]: 8186443: Missing stdint.h for zero builds

David Holmes david.holmes at oracle.com
Tue Aug 22 13:00:20 UTC 2017

On 22/08/2017 10:54 PM, John Paul Adrian Glaubitz wrote:
> On 08/22/2017 02:51 PM, David Holmes wrote:
>> http://cr.openjdk.java.net/~glaubitz/8186443/webrev.01/hotspot.patch
>> is just a basic patch, containing only the diff for the two files. Yet 
>> your webrev shows e.g.:
>> rev 13458 : 8186443: Missing stdint.h for zero builds
>> Reviewed-by: kbarrett, dholmes
>> which is the details of the commit message. If I do a commit and then 
>> generate the
>> webrev the patch file is the actual changeset in a format that can be 
>> directly
>> imported by "hg import" including the user identity, the bug 
>> attribution and reviewers.
>> That's the format I get from others.
> Oh, ok. I used "webrev -N -r $REV" to create it. Do I need to pass other 
> options?

I think you need to drop the -N, and possibly the -r rev too. I don't 
pass any specific options, except -m to force mercurial.


> Adrian

More information about the hotspot-dev mailing list