RFR: 8186476: Generalize Atomic::add with templates

Erik Österlund erik.osterlund at oracle.com
Tue Aug 22 14:02:13 UTC 2017

Hi Andrew,

On 2017-08-22 11:06, Andrew Haley wrote:
> On 21/08/17 14:10, Erik Österlund wrote:
>> When it comes to the proposed Atomic::add implementation, it seems to me
>> like the emulation of Atomic::add on jshort using jint is very similar
>> to how Atomic::cmpxchg on jbyte is emulated using jint. So it surprised
>> me a bit that Atomic::add of jshort does not share the same mechanism as
>> the generalized Atomic::cmpxchg of jbyte.
> Indeed.  It also seems rather weird to jump through these hoops on
> targets which do have support for adds on jshort.  Still, as you say
> it's only used in once place and I guess it doesn't hurt.  I don't
> like the undefined behaviour there, though.  It would be nice if there
> were none on targets with proper support.

Is that a request or are you happy enough with the proposed solution?
In case it was really meant as a request, how about something like this?




More information about the hotspot-dev mailing list