RFR 8173715 (rev2): Remove Flat Profiler
david.holmes at oracle.com
Wed Aug 23 02:06:03 UTC 2017
On 22/08/2017 5:59 PM, Vladimir Ivanov wrote:
> Looks good.
On compiler-dev Gerard specifically asks:
Can someone please review the
"hotspot/src/cpu/sparc/vm/macroAssembler_sparc.cpp” file to determine
whether we still need the three "save_frame_and_mov(0, Lmethod,
Lmethod);” calls where the comment said it was needed by -Xprof?
Do we leave those save_frame_and_mov() calls as is (and add comment as
to why they are still needed), or can we change them into save_frame()
Can you clarify this please.
> Best regards,
> Vladimir Ivanov
> On 8/19/17 12:00 AM, Gerard Ziemski wrote:
>> hi all,
>> The FlatProfiler (i.e. -Xprof) has been deprecated in jdk9, and now
>> it’s the time to remove the code and obsolete the -Xprof flag.
>> Changes from rev1 to address David’s feedback:
>> - obsoleted the flag (it’s still accepted, but ignored)
>> - fixed copyright year in
>> - improved comment about the signal based suspend/resume mechanism in
>> "os_*.cpp” files
>> - removed entire comment from "src/os/solaris/vm/osThread_solaris.hpp"
>> issue: https://bugs.openjdk.java.net/browse/JDK-8173715
>> webrev: http://cr.openjdk.java.net/~gziemski/8173715_rev2_hotspot
More information about the hotspot-dev