RFR: 8174050: Compilation errors with clang-4.0

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Aug 23 22:39:13 UTC 2017

Thank you, Martin

Yes, sign compare is bad for pointers.

Note, for pointers compare with use NULL instead of 0. Please, use NULL.

The assert check in loopPredicate.cpp is simple missing reference to 
field _lo (low bound of values range):

  _igvn.type(rng)->is_int()->_lo >= 0

Please, fix it this way.


On 8/23/17 2:25 PM, Martin Buchholz wrote:
> https://bugs.openjdk.java.net/browse/JDK-8174050
> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/pointer-sign-comparison/
> My webrev could go in as is, but better would be for someone to figure out
> the intent of the nonsensical assert in
> src/share/vm/opto/loopPredicate.cpp
> (There is more to be done to support clang, but this is enough to build
> openjdk without patching source)

More information about the hotspot-dev mailing list