Name clashes - was: Re: [RFR]: 8186723: Add SuperH as new architecture for linux
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Thu Aug 24 13:24:55 UTC 2017
On 08/24/2017 03:20 PM, David Holmes wrote:
> Ouch! So I have to wonder whether the raw -D for the cpu arch name is really necessary.
> There's obviously a lot of legacy usage to consider here though. But I've often assumed/
> expected that if we tell the compiler to build for a specific cpu then the compiler would
> provide a suitable define (probably underscored) that we could then use in the code if needed.
I agree. The string "LEGACY" in the identifier seems to confirm that. Might be a good idea
to open a separate bug for the removal of this identifier.
> Short-term solution would be your option (b) and rename alpha and sh to something unlikely to cause a clash.
I guess we can merge 8186723 without any changes then? It doesn't rely on the legacy
(lowercase) identifier but on the all-uppercase identifier anyways.
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz at debian.org
`. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the hotspot-dev