RFR 8173715 (rev2): Remove Flat Profiler

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Mon Aug 28 13:49:08 UTC 2017

> On compiler-dev Gerard specifically asks:
> Can someone please review the 
> "hotspot/src/cpu/sparc/vm/macroAssembler_sparc.cpp” file to determine 
> whether we still need the three "save_frame_and_mov(0, Lmethod, 
> Lmethod);” calls where the comment said it was needed by -Xprof?
> Do we leave those save_frame_and_mov() calls as is (and add comment as 
> to why they are still needed), or can we change them into save_frame() 
> calls?

I don't have a strong opinion, but I'd prefer to keep them as is.

Though all 3 usages are in debug code (either guarded by #ifdef ASSERT 
or VerifyThread), the code is transitively used in template interpreter.

So, I suspect dropping Lmethod will break interpreter stack frame 
attribution (frame::is_interpreted_frame_valid) in those narrow periods 
when temporary frames are alive and will affect JFR & AsyncGetCallTrace().

Best regards,
Vladimir Ivanov

More information about the hotspot-dev mailing list