[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Tue Aug 29 22:16:41 UTC 2017


Here's my suggested change to fix the Zero build on linux-sparc.

The first part of the change removes the unnecessary include of
vmreg_sparc.inline.hpp in src/share/vm/compiler/oopMap.cpp.

The second change moves src/cpu/sparc/vm/memset_with_concurrent_readers_sparc.cpp
into the generic location src/share/vm/gc/shared/memset_with_concurrent_readers_sparc.cpp,
so it is picked up both during the Server and Zero builds on linux-sparc.

In order to prevent src/share/vm/gc/shared/memset_with_concurrent_readers_sparc.cpp
from being built on non-SPARC targets - which would fail because of the inline
assembly - I have guarded the entire file's definitions with "#ifdef SPARC #endif".

I know the last bit of this changeset might not be the most elegant one, but
it's the least intrusive I could come up with and it fully fixes the Zero builds
for me on linux-sparc.


> [1] http://cr.openjdk.java.net/~glaubitz/8186578/webrev.00/

  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

More information about the hotspot-dev mailing list