RFR: JDK-8190484 Move jvm.h, jmm.h et al to hotspot/*/include

mandy chung mandy.chung at oracle.com
Tue Dec 5 00:13:12 UTC 2017

On 12/4/17 3:59 PM, Magnus Ihse Bursie wrote:
>>> And classfile_constants.h is also distributed with the image. I am
>>> unsure of the intent/history. To play it safe i will just bump the
>>> number.
>> Hmmm - that seems wrong. jvm.h is not an exported external interface 
>> AFAIK. And we just moved it so I don't think it will get distributed 
>> any more. Hmm that also suggests that classfile_constants.h may be in 
>> the wrong place ... I'll take this up elsewhere.
>> ---
>> So is classfile_constants.h also in the wrong place? And should it be 
>> in the image ??
> It sounds like it. :( It's only included from jvm.h (and 
> src/java.base/share/native/libverify/check_code.c) as far as I can 
> tell. So it should probably move with jvm.h.
> The bad news is that I just pushed JDK-8190484. (To jdk/hs; Jesper 
> promised me to make sure it ended up in jdk/jdk before RDP1). The good 
> news is that just moving classfile_constants.h is probably simple, I 
> assume all include paths are already correct.
> Can you open a new bug (and/or handle it all by yourself)?

classfile_constants.h was added to ${java.home}/include in JDK 6 [1] as 
an exported interface.   It was intended for BCI native agent to use.  
With the removal of JVM TI demos, I think we should revisit if 
classfile_constants.h should be distributed.

As far as JDK-8190484, the changeset adequately covers the non-exported 
header files.

[1] https://bugs.openjdk.java.net/browse/JDK-5107600

More information about the hotspot-dev mailing list