RFR: 8192123: Zero should use compiler built-ins for atomics on linux-arm

Andrew Haley aph at redhat.com
Fri Dec 22 14:46:35 UTC 2017

On 29/11/17 15:39, coleen.phillimore at oracle.com wrote:
> On 11/29/17 10:04 AM, Andrew Haley wrote:
>> On 29/11/17 14:08, John Paul Adrian Glaubitz wrote:
>>> Since the compiler built-ins for cmpxchg() work exactly like the current ARM-specific
>>> implementation in Zero, there is no need anymore to carry our own implementation but
>>> rather rely on gcc which helps simplifying the code.
>>> I have successfully tested this change in the following targets:
>>> - Linux ARMv4T
>>> - Linux ARMv7
>>> My change also removes a single empty line to make the formatting more
>>> consistent. Hope this is ok.
>> Hmm.  This doesn't fix a bug, and there's a non-zero probability of
>> introducing one.  I guess it should be OK, but this is a combination
>> of performance improvement (possibly) and cleanup.
> Please save this change for JDK 11.

It's fine for JDK 11.

Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-dev mailing list