RFR: 8178495: Bug in the align_size_up_ macro

Stefan Karlsson stefan.karlsson at oracle.com
Sat Jul 1 07:01:04 UTC 2017

On 2017-07-01 01:21, Kim Barrett wrote:
>> On Jun 30, 2017, at 11:15 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>> Fixing the logging with SCOPED_TRACE was only tested locally, but failed on OSX. Here's a fix for that problem:
>> http://cr.openjdk.java.net/~stefank/8178495/webrev.02
>> http://cr.openjdk.java.net/~stefank/8178495/webrev.02.delta
>> Passes JPRT now.
>> StefanK
> Looks good.

Thanks for reviewing.

> I think I see where things might have gone awry, but I’m curious what the OSX failure was.
> I’m a bit surprised that it complained but other compilers didn’t.

This was the error message:

hotspot/test/native/utilities/test_align.cpp:40:18: note: expanded from macro 'log'
#define log(...) SCOPED_TRACE(err_msg(__VA_ARGS__))
test/fmw/gtest/include/gtest/gtest.h:2172:49: note: expanded from macro 'SCOPED_TRACE'
     __FILE__, __LINE__, ::testing::Message() << (message))
hotspot/src/share/vm/utilities/formatBuffer.hpp:65:3: note: declared private here
   FormatBuffer(const FormatBuffer &); // prevent copies

The jprt run was aborted after this failure, so it could be that this would have failed on Windows and Solaris as well.



More information about the hotspot-dev mailing list