RFR: compile-time guard some UseSharedSpaces-only coding with the INCLUDE_CDS macro - was :RE: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro
matthias.baesken at sap.com
Thu Jul 13 12:18:56 UTC 2017
> Thank you for noticing that. Yes, it would be helpful if you can add the #if INCLUDE_CDS for CDS only code.
> I can help you integrate the changes after they are reviewed.
Thanks for your feedback !
I created a bug :
and a webrev :
Best regards, Matthias
From: Jiangli Zhou [mailto:jiangli.zhou at oracle.com]
Sent: Montag, 10. Juli 2017 17:54
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: hotspot-dev at openjdk.java.net; build-dev at openjdk.java.net
Subject: Re: jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro
Thank you for noticing that. Yes, it would be helpful if you can add the #if INCLUDE_CDS for CDS only code. I can help you integrate the changes after they are reviewed.
> On Jul 5, 2017, at 6:36 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> Hello, when looking into CDS related build options, I noticed that most code-parts that are executed only when UseSharedSpaces is set,
> are guarded by the compile-time macro INCLUDE_CDS to support switching off compilation of this coding
> when CDS is disabled at compile time :
> See hotspot/make/lib/JvmFeatures.gmk :
> ifneq ($(call check-jvm-feature, cds), true)
> JVM_CFLAGS_FEATURES += -DINCLUDE_CDS=0
> However some places miss the compile-time guarding ( #if INCLUDE_CDS ....) for example in
> (also some other places)
> Should I prepare a change and add the compile-time guard at the places where missing as well ?
> Best regards, Matthias
More information about the hotspot-dev