[10] RFR: 8184309: Buld warnings from GCC 7.1 on Fedora 26

Kim Barrett kim.barrett at oracle.com
Thu Jul 13 17:13:33 UTC 2017

> On Jul 12, 2017, at 9:03 PM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> Thanks Kim, Vladimir,
>> Could this one instead be fixed by changing the declaration of TimestampFormat from
>> static const char*  TimestampFormat;
>> to
>> static const char*  const TimestampFormat;
> It works fine.
> So I use it.
> I filed this issue as JDK-8184309, and uploaded webrev.
> It does not contain the warning of methodMatcher.cpp .
> Could you review it?
> http://cr.openjdk.java.net/~ysuenaga/JDK-8184309/webrev.00/

Thanks for cleaning these up.

In context, the addition of the const qualifier to just
TimestampFormat looks odd, and made me look at the others nearby.
I think all those other nearby "const char*" variables ought to
be "const char* const" too.

If you want to make that change (and assuming I haven't overlooked
something, and it builds ok), I don't need another round of review.

Looks good.

More information about the hotspot-dev mailing list