RFR: 8184309: Buld warnings from GCC 7.1 on Fedora 26
yasuenag at gmail.com
Fri Jul 14 01:57:37 UTC 2017
I uploaded new webrev for this issue:
Vladimir, could you push this patch?
2017-07-14 2:13 GMT+09:00 Kim Barrett <kim.barrett at oracle.com>:
>> On Jul 12, 2017, at 9:03 PM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>> Thanks Kim, Vladimir,
>>> Could this one instead be fixed by changing the declaration of TimestampFormat from
>>> static const char* TimestampFormat;
>>> static const char* const TimestampFormat;
>> It works fine.
>> So I use it.
>> I filed this issue as JDK-8184309, and uploaded webrev.
>> It does not contain the warning of methodMatcher.cpp .
>> Could you review it?
> Thanks for cleaning these up.
> In context, the addition of the const qualifier to just
> TimestampFormat looks odd, and made me look at the others nearby.
> I think all those other nearby "const char*" variables ought to
> be "const char* const" too.
> If you want to make that change (and assuming I haven't overlooked
> something, and it builds ok), I don't need another round of review.
> Looks good.
More information about the hotspot-dev