[8u] RFR for backport of JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4
vladimir.kozlov at oracle.com
Mon Jul 24 16:21:57 UTC 2017
This looks good.
On 7/23/17 11:56 PM, Muthusamy Chinnathambi wrote:
> Hi Vladimir,
> Thanks for the review.
> Please find the updated webrev at http://cr.openjdk.java.net/~shshahma/Muthu/8158012/webrev.01/
> Muthusamy C
> -----Original Message-----
> From: Vladimir Kozlov
> Sent: Friday, July 21, 2017 4:38 AM
> To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>; hotspot-dev at openjdk.java.net
> Subject: Re: [8u] RFR for backport of JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4
> The indent for next comment line in vm_version_sparc.cpp is off:
> // Use BIS instr
> And AllocatePrefetchStyle set to 3 should be outside new check (should
> be set for both cases). In JDK 9 there is following code which set it
> for AllocatePrefetchInstr == 1 which JDK8 does not have:
> On 7/20/17 12:24 AM, Muthusamy Chinnathambi wrote:
>> Please review the backport of bug: "JDK-8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4" to jdk8u-dev
>> Please note that this is not a clean backport due to conflict in comments and slight re-order of code.
>> Webrev: http://cr.openjdk.java.net/~shshahma/Muthu/8158012/webrev.00/
>> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8158012
>> Original patch pushed to jdk9: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/eebdc7acebd4
>> Test: Ran jprt and jtreg.
>> Muthusamy C
More information about the hotspot-dev