RFR (L but tedious) 8183039: Re-examine methodHandle methods uninlined by 8144256

harold seigel harold.seigel at oracle.com
Thu Jul 27 14:16:13 UTC 2017

Hi Coleen,

The changes look good!

One small nit, in rewriter.cpp, Rewriter::rewrite_jsrs(), could this:

    + methodHandle new_method = method;
    + new_method = romc.do_potential_rewrite(CHECK_(methodHandle()));

just be:

    + methodHandle new_method =

No need for a new webrev.

Thanks, Harold

On 7/27/2017 9:19 AM, coleen.phillimore at oracle.com wrote:
> Summary: Add more const references so out-of-line methodHandle 
> destructor and copy ctor called infrequently
> See RFE for more details.   In short, use const methodHandle& when 
> possible.
> open webrev at http://cr.openjdk.java.net/~coleenp/8183039.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8183039
> Tested with RBT on linux, solaris and windows (still running) with 
> tier2 testing and all tier1-5 tests on linux x64.
> Thanks,
> Coleen

More information about the hotspot-dev mailing list