RFR: 8161145: The min/max macros make hotspot tests fail to build with GCC 6

Kim Barrett kim.barrett at oracle.com
Thu Jun 1 08:18:36 UTC 2017

> On May 31, 2017, at 11:01 AM, Erik Österlund <erik.osterlund at oracle.com> wrote:
> Hi,
> Excellent. In that case I would like reviews on this patch that does exactly that:
> http://cr.openjdk.java.net/~eosterlund/8161145/webrev.00/
> Testing: JPRT
> Need a sponsor.

FWIW, another option would be to remove all the min/max stuff here,
and add -DNOMINMAX (or whatever the proper syntax is) in the Windows
build configuration.  I did some later research on JDK-8161145, and
defining that macro seems to be the "official" way to suppress those
macros in the offending windows header.

The proposed change also seems fine to me, not surprisingly.  Under the
circumstances, not sure I should be counted as a reviewer :)

I can sponsor though.

More information about the hotspot-dev mailing list