[PATCH] linux-sparc build fixes

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Sat Jun 17 23:40:06 UTC 2017

Hi Erik!

On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote:
> On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
>> thanks for contributing and signing the OCA!
> Thanks for reviewing my patches ;-).

My OCA has been completed now and I'm now showing up on the list
of signees:

> http://www.oracle.com/technetwork/community/oca-486395.html

So, at least from the bureaucracy side, I should be all set now.

>> I think the first three patches (hotspot-add-missing-log-header.diff,
>> hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all
>> look good, thanks for fixing broken code. Consider them Reviewed by me.
>> Every patch needs a corresponding issue in the bug tracker, so I went ahead
>> and created:
>> - https://bugs.openjdk.java.net/browse/JDK-8182163
>> - https://bugs.openjdk.java.net/browse/JDK-8182164
>> - https://bugs.openjdk.java.net/browse/JDK-8182165

So, for these three patches. What else needs to be done to get them
in a state so they can be merged? I understand they need to be reviewed
by a second reviewer as they concern Hotspot code.

In another message, you also mentioned:

> Also, have you run the tier 1 testing for hotspot (the tests that need to
> pass for every commit)? You can run those tests by running (from the
> top-level "root" repo):
> $ make test TEST=hotspot_tier1
> or, if you want to try the new run-test functionality
> $ make run-test-hotspot_tier1

Should those be run on the Linux sparc64 machine or just on Linux x86_64?

I'm asking because running the testsuite on Linux sparc64 will only be
possible with all four patches applied as they are build fixes. Running
the testsuite on Linux x86_64 will be possible, of course.

After fixing the build on Linux sparc, I will have more patches ready
to fix the Zero builds on even more targets ;-).


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

More information about the hotspot-dev mailing list