RFR: JDK-8172791 fixing issues with Reserved Stack Area

Andrew Haley aph at redhat.com
Fri Jun 30 15:03:37 UTC 2017

Just to explain why this patch is needed: without it, JEP 270
(ReservedStackArea) does not work at all if a method with a
ReservedStack annotation is inlined.  Which, in practice, is all the
time, because aggressive inlining is what C2 does.

Can somebody please have a look at this?

On 18/04/17 15:47, Frederic Parain wrote:
> Greetings,
> Please review this fix which addresses several issues with the 
> ReservedStackArea implementation:
>    1 - the method look_for_reserved_stack_annotated_method() fails to 
> detect in-lined
>         annotated methods, making the annotation ineffective for 
> in-lined methods
>    2 - sometime an assertion failure related to reserved area status 
> occurs after incorrect
>         restoring of guards pages during a return from runtime
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8172791
> webrev:
> http://cr.openjdk.java.net/~fparain/8172791/webrev.00/index.html
> This fix has been contributed by Andrew Haley.
> Thank you,
> Fred

Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-dev mailing list