RFR (L) 8186777: Make Klass::_java_mirror an OopHandle

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Oct 2 15:31:22 UTC 2017

On 10/2/17 11:18 AM, Tobias Hartmann wrote:
> Hi Coleen,
> On 28.09.2017 23:36, coleen.phillimore at oracle.com wrote:
>> http://cr.openjdk.java.net/~coleenp/8186777.02/webrev/
>> Can I get at least 3 reviewers?  One from each of the compiler, gc, 
>> and runtime group at least since there are changes to all 3.
> The compiler changes look good to me.
> Found a little typo:
> - In line 1776 of memnode.cpp: it should be "loads" instead of "load"

Thank you Tobias.  I fixed this typo.
> I just wanted to mention that SharkIntrinsics::do_Object_getClass() 
> would need to be fixed as well but I've seen that you filed 
> JDK-8171853 [1] to remove Shark which is broken with JDK 9 anyway.

Yes, I think we've broken shark for a while now and it should be 
removed, unless someone in the open wants to take it over.   I don't 
have any idea how to build it anymore.

> Best regards,
> Tobias
> [1] https://bugs.openjdk.java.net/browse/JDK-8171853

More information about the hotspot-dev mailing list