RFR: 8189333: Fix Zero build after Atomic::xchg changes

Roman Kennke rkennke at redhat.com
Mon Oct 16 13:45:00 UTC 2017

Hi Coleen,

Nope. It fails with this (and a bunch of similar) errors:

It does build with this additional patch:

- cast BasicLock to markOop by using markOopDesc::encode()
- use oopDesc::cas_set_mark() instead of the raw Atomic ops (probably 
not strictly required for this change, but still much nicer)

You should not require any build scripts for Zero though. Simply run 
configure with --with-jvm-variants=zero and build in the corresponding 
linux-x86_64-normal-zero-slowdebug or similar directory using the usual 
make calls.

> Hi Roman, Can you build zero with this changeset?
> http://cr.openjdk.java.net/~coleenp/8188220.03/webrev/index.html
> My scripts for building zero are broken now.
> thanks,
> Coleen
> On 10/15/17 5:40 PM, Roman Kennke wrote:
>> Am 15.10.2017 um 23:32 schrieb David Holmes:
>>> Hi Roman,
>>> On 16/10/2017 7:12 AM, Roman Kennke wrote:
>>>> Zero debug build has been broken by: JDK-8187977: Generalize 
>>>> Atomic::xchg to use templates.
>>>> This patch fixes it by casting the unsigned literal to jint:
>>>> http://cr.openjdk.java.net/~rkennke/8189333/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Erkennke/8189333/webrev.00/>
>>> Looks fine.
>>> I can push this for you straight away (relatively speaking :) ) 
>>> under the trivial rule.
>> Thanks!
>> Roman

More information about the hotspot-dev mailing list