[PATCH] JDK-8025886: Replace [[ and == bash extensions in tests
david.holmes at oracle.com
Mon Dec 10 07:25:17 UTC 2018
Sorry to be a pain but you do need to send the request to the
appropriate mailing list for the "owner" of the code being changed. In
is not hotspot code but JDK Monitoring&Management code, which I think is
covered by serviceability-dev.
On 9/12/2018 6:42 am, Sergey wrote:
> I've recently been working on bug
> that is mainly about cleaning up the [[ and == bash
> extensions from the tests.
> I've discovered, that there's a leftover after hg forest
> consolidation. GeneratePropertyPassword.sh script
> still uses beforementioned bash extensions. That has
> been fixed within the scope of this bug:
> Though fix didn't get to the consolidated forest.
> The fix is trivial and just reapplies the patch from the
> JBS' comments. Change has been tested with `dash`
> and works fine.
> Please find the patch inlined below. That would also be
> great if anyone could sponsor it.
> diff --git
> @@ -34,12 +34,13 @@
> OS=`uname -s`
> -if [[ $OS == CYGWIN_NT* ]] ; then
> +case $OS in
> if [ -z "$SystemRoot" ] ; then
> - SystemRoot=`cygpath $SYSTEMROOT`
> + SystemRoot=$SYSTEMROOT
> case $OS in
> SunOS | Linux | Darwin | AIX )
More information about the hotspot-dev