RFR (XS) [12] 8215374: 32-bit build failures after JDK-8181143 (Introduce diagnostic flag to abort VM on too long VM operations)

Aleksey Shipilev shade at redhat.com
Thu Dec 13 21:42:16 UTC 2018


With all the excitement around fixing x86_32 issues before jdk12 fork today, I forgot to test my own
patch still builds on x86_32! It does not, because format specifiers are wrong. Fix:

diff -r 408cdb799358 -r 1fb17b0a42c2 src/hotspot/share/runtime/vmThread.cpp
--- a/src/hotspot/share/runtime/vmThread.cpp    Thu Dec 13 22:32:38 2018 +0100
+++ b/src/hotspot/share/runtime/vmThread.cpp    Thu Dec 13 22:32:39 2018 +0100
@@ -206,7 +206,7 @@
   if (is_armed()) {
     jlong delay = (os::javaTimeMillis() - _arm_time);
     if (delay > AbortVMOnVMOperationTimeoutDelay) {
-      fatal("VM operation took too long: " SIZE_FORMAT " ms (timeout: " SIZE_FORMAT " ms)",
+      fatal("VM operation took too long: " JLONG_FORMAT " ms (timeout: " INTX_FORMAT " ms)",
             delay, AbortVMOnVMOperationTimeoutDelay);

This goes to jdk/jdk12, because the bug is there. This build failure is currently masked by another
x86_32 build failure, fixed by JDK-8215353, which would be pushed before this fix.

Testing: {x86_32, x86_64} build, AbortVMOnVMOperationTimeout test


More information about the hotspot-dev mailing list