RFR: [XS] 8215411: some GetByteArrayElements calls miss corresponding Release
jcbeyler at google.com
Mon Dec 17 17:25:41 UTC 2018
Your webrev looks good to me (not a reviewer though ;-)). I saw a few
things about the isCopy updates but that is out of scope of this webrev,
I'll be creating a separate one in a bit :-)
On Mon, Dec 17, 2018 at 1:00 AM Baesken, Matthias <matthias.baesken at sap.com>
> Hello, please review the following change.
> I noticed that we miss at some places (for example in case of early
> where GetByteArrayElements is used, the corresponding
> ReleaseByteArrayElements call.
> In VirtualMachineImpl.c I also removed a check for isCopy (is the
> returned byte array a copy ?)
> because from what I read at
> the ReleaseByteArrayElements routine should always be called.
> bug/webrev :
> Thanks, Matthias
More information about the hotspot-dev