[11] RFR jck test fails with C2: vm/jvmti/FollowReferences/fref001/fref00113/fref00113.html

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Jul 3 17:25:43 UTC 2018

On 7/3/18 12:26 PM, Paul Sandoz wrote:
>> On Jul 2, 2018, at 11:43 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> On 7/2/18 10:39 AM, Paul Sandoz wrote:
>>> Hi,
>>> Please review this fix for 11:
>>>    http://cr.openjdk.java.net/~psandoz/jdk/JDK-8202769-ci-stream-cp-tag/webrev/
>> Seems good to me. I will run testing with it.
> Thanks, i see all relevant tests pass, so ok to push?

You need two reviewers, and are you pushing this to JDK11 ?

The patch in the bug report seems better because you don't know that all 
of the callers want to convert JVM_CONSTANT_Dynamic to the underlying 
type that the Symbol points to.  The name of the ciStream function 
implies that it just returns tag_at().   I would assume that there would 
be other callers that want to do something with the actual tag, like 
print the bytecode stream for example.


> Paul.

More information about the hotspot-dev mailing list