RFR 8199868: Support JNI critical functions in object pinning API

Zhengyu Gu zgu at redhat.com
Tue Jul 31 13:25:38 UTC 2018

Hi Andrew,

Thanks for reviewing.

On 07/31/2018 07:10 AM, Andrew Dinn wrote:
> Zhengyu, I think you need to add an explanation of how this test will
> catch errors that might arise in pinning and, in doing so, perhaps
> comment on a few details of what the test does, viz: What is the point
> of allocating the garbage arrays? What is the point of using
> THREAD_PER_CASE * 2 threads. Why make the run methods iterate CYCLES times?

I added comments as you suggested.

Updated webrev: http://cr.openjdk.java.net/~zgu/8199868/webrev.04/


> regards,
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the hotspot-dev mailing list