RFR(L) : 8202812 : [TESTBUG] Open source VM testbase compiler tests

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Fri Jun 1 01:43:48 UTC 2018

Looks good to me.

One comment though:
   - copyright header needs to be updated
      please update the copyright statement prior to integration; no 
need for a new webrev

Thank you,

On 5/18/18, 10:50 AM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8202812/webrev.00/index.html
>> 56733 lines changed: 56732 ins; 0 del; 1 mod; 1
> Hi all,
> could you please review the patch which open sources compiler tests from vm testbase? these tests were developed in different time to cover different parts of JITs.
> As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8202812
> webrev: http://cr.openjdk.java.net/~iignatyev/8202812/webrev.00/index.html
> testing: :vmTestbase_vm_compiler test group
> Thanks,
> -- Igor

More information about the hotspot-dev mailing list