RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

Stefan Johansson stefan.johansson at oracle.com
Fri Jun 1 09:04:23 UTC 2018

On 2018-05-31 15:53, Stefan Karlsson wrote:
> Hi all,
> Please review this patch to lower the minimum number of heap memory 
> pools in MemoryTest.java.
> http://cr.openjdk.java.net/~stefank/8204173/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8204173
> Just like the comment in the test says:
>  * NOTE: This expected result is hardcoded in this test and this test
>  * will be affected if the heap memory layout is changed in
>  * the future implementation.
>  */
> we need to update this test to support ZGC, which only has one heap 
> memory pool.
The change looks good, but I think maybe you should update the comment 
about the pools a bit. I'm not sure why we have the history lesson in 
the comment. I would much rather have a comment describing the current 
state and since the test live with the code this should be just fine. 
But leave the NOTE, it is good to be explicit when we depend on hard 
coded stuff :)


> Thanks,
> StefanK

More information about the hotspot-dev mailing list