RFR(L) : 8202812 : [TESTBUG] Open source VM testbase compiler tests
igor.ignatyev at oracle.com
Fri Jun 1 20:28:36 UTC 2018
I've filed 8204248 to reevaluate these tests from (at least) triggering JIT compilation perspective (at most overall value for testing). as this patch doesn't really introduce these tests, I don't consider their current state as blocker for open sourcing. so if you don't object, I'll push 8202812 patch and we will work on 8204248 later.
 https://bugs.openjdk.java.net/browse/JDK-8204248 <https://bugs.openjdk.java.net/browse/JDK-8204248>
> On Jun 1, 2018, at 9:52 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> On 5/31/18 12:19 PM, Igor Ignatyev wrote:
>>> On May 31, 2018, at 12:06 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> Looks good to me.
>> thanks for reviewing it!
>>> I don't understand how these tests trigger JIT compilation? main() does not have any loops.
>> which test/tests are you asking about? I've looked at a few tests, all of them do have loops (not necessary right in main). in any case, this is how these tests were for a long time, they definitely require reevaluation and rewriting.
> Almost all /jit/ tests don't have loops:
> They like just JCK tests to me. Should we run them with -Xcomp? Or you have a "driver" which trigger JIT compilation for these tests?
>>> Where is GoldChecker class?
>> GoldChecker is defined in test/hotspot/jtreg/vmTestbase/nsk/share/GoldChecker.java, which has been integrated by 8199643: [TESTBUG] Open source common VM testbase code.
>>> What --java flag mean in @run command?
>> "--java" isn't a flag of @run, it's the flag of ExecDriver (test/hotspot/jtreg/vmTestbase/ExecDriver.java) which makes it to interpret the rest of arguments as regular arguments of java. ExecDriver is needed by some tests b/c they either run package-private classes (which regular jtreg's @run can't do) or use zero-exit code to signalize passed status (jtreg treats only 95 as passed). ExecDriver was used to reduce changes in the tests during their conversion to jtreg format and eventually it should go for good.
>> -- Igor
>>> On 5/18/18 10:50 AM, Igor Ignatyev wrote:
>>>>> 56733 lines changed: 56732 ins; 0 del; 1 mod; 1
>>>> Hi all,
>>>> could you please review the patch which open sources compiler tests from vm testbase? these tests were developed in different time to cover different parts of JITs.
>>>> As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them.
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8202812
>>>> webrev: http://cr.openjdk.java.net/~iignatyev/8202812/webrev.00/index.html
>>>> testing: :vmTestbase_vm_compiler test group
>>>> -- Igor
More information about the hotspot-dev