RFR: 8204476: Add additional statistics to CodeCache::print_summary
thomas.stuefe at gmail.com
Thu Jun 7 19:11:29 UTC 2018
On Thu, Jun 7, 2018 at 9:37 AM, René Schünemann
<rene.schuenemann at gmail.com> wrote:
> can I please get a review for the following change:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8204476
> Webrev: http://cr.openjdk.java.net/~goetz/wr18/rene/webrev_8204476/01/
> This change adds the following:
> (1) In CodeCache::print_summary prints the code cache full count for
> each code heap.
> (2) Adds additional counters to class CompileBroker:
> _total_compiler_stopped_count: The number of times the compilation
> has been stopped.
> _total_compiler_restarted_count: The number of times the
> compilation has been restarted.
> This counters are also added to CodeCache::print_summary.
> Thank you,
Apart from what Vladimir wrote:
- small nit: _total_compiler_restarted_count += 1; ->
- Please either use %d for printing int or change the type to
uint32_t. But seeing that the other counters are int, I would use %d.
- More of a question to others: I am not familiar with compiler
coding, but signed int as counters seem a bit small? Is there no
danger of ever overflowing on long running VMs? Or does it not matter
if they do?
More information about the hotspot-dev