RFR: 8204477: Count linkage errors and print in Exceptions::print_exception_counts_on_error

Thomas Stüfe thomas.stuefe at gmail.com
Thu Jun 7 19:34:40 UTC 2018

Hi Rene,

Looks good overall. This is a useful addition.

-  155     Atomic::inc(&Exceptions::_linkage_errors);
   you can loose the "Exceptions::" scope since we are in the Exceptions class.

- Can you please add #include runtime/atomic.hpp to the file? It is
missing that header.

- Please make _linkage_errors class private. It is not directly
accessed from outside. (_stack_overflow_errors on the other hand is,
so it has to be public).

If you fix these points, I do not need a new webrev.

Best Regards, Thomas

On Thu, Jun 7, 2018 at 9:29 AM, René Schünemann
<rene.schuenemann at gmail.com> wrote:
> Hi,
> can I please get a review for the following change:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8204477
> Webrev: http://cr.openjdk.java.net/~goetz/wr18/rene/webrev_8204477/01/
> This change counts linkage errors and prints the number of linkage
> errors thrown in the Exceptions::print_exception_counts_on_error,
> which is used when writing the hs_error file.
> Thank you,
> Rene

More information about the hotspot-dev mailing list