[aarch64-port-dev ] RFR(S): 8204628 [AArch64] Assertion failure in BarrierSetAssembler::load_at

White, Derek Derek.White at cavium.com
Fri Jun 8 22:22:46 UTC 2018

Hi Stuart,

Can you lose the declaration of BarrierSetAssembler bs at line 2116? This looks good otherwise.
- Derek

> -----Original Message-----
> From: aarch64-port-dev [mailto:aarch64-port-dev-
> bounces at openjdk.java.net] On Behalf Of Stuart Monteith
> Sent: Friday, June 08, 2018 6:07 PM
> To: aarch64-port-dev <aarch64-port-dev at openjdk.java.net>; hotspot-dev
> Source Developers <hotspot-dev at openjdk.java.net>; Erik Osterlund
> <erik.osterlund at oracle.com>
> Subject: [aarch64-port-dev ] RFR(S): 8204628 [AArch64] Assertion failure in
> BarrierSetAssembler::load_at
> Hello,
>     Please review a patch for "8204628  [AArch64] Assertion failure in
> BarrierSetAssembler::load_at".
> Currently you won't be able to build aarch64 debug builds because of
> assertions tripping in load_at.
> JDK-8203353 refined the decorators somewhat, which worked fine on x86,
> but not aarch64.
> In this patch, I change the code to match x86's in that access_load_at is
> called instead of load_at, which means that AccessInternal::decorator_fixup
> is called, which fixes the expectations of the assertions in load_at and other
> places. The accesses of load_at and access_load_at  (and store equivalents)
> now match x86.
> CR: https://bugs.openjdk.java.net/browse/JDK-8204628
> webrev: http://cr.openjdk.java.net/~smonteith/8204628/webrev/
> The assertions no longer trip when tested with C1 or C2.
> Many thanks,
>     Stuart

More information about the hotspot-dev mailing list