RFR: 8204476: Add additional statistics to CodeCache::print_summary
rene.schuenemann at gmail.com
Mon Jun 11 10:52:55 UTC 2018
Thank you Vladimir and Thomas!
I have moved the output of code cache full count to a separated line.
It now shows an accumulated number, but I think, that should be
Updated Webrev: http://cr.openjdk.java.net/~goetz/wr18/rene/webrev_8204476/02/
On Sat, Jun 9, 2018 at 5:25 PM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
>>> - More of a question to others: I am not familiar with compiler
>>> coding, but signed int as counters seem a bit small? Is there no
>>> danger of ever overflowing on long running VMs? Or does it not matter
>>> if they do?
>> I never observed compilations count over 1M (10^6). And there is no issue if
>> they overflow - it is just number printed in statistic and logs. We have
>> also use it as compilation task id and I think it is also safe.
>> Note, in stable application case you should not have a lot of compilations.
>> It should not be more than application's + system's hot methods.
>> New counters in this change are much smaller - they count how many times
>> CodeCache become full which should not happen in normal case.
> Ah, thanks for clarifying.
> Best Regards, Thomas
>>> Thanks, Thomas
More information about the hotspot-dev