RFR: 8204585: Remove IN_ARCHIVE_ROOT from Access API

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Jun 11 23:00:33 UTC 2018

This looks good.

On 6/11/18 6:26 PM, Jiangli Zhou wrote:
> Hi Kim,
> Both the changes and testing look good to me. Would it be better to rename MetaspaceShared::unarchive_heap_object() to MetaspaceShared::materialize_archived_object() to reflect the API in G1CollectedHeap? The use of ‘materialize’ in the GC API looks very good. Thank you for continuing improving the GC underlying support!
> Thanks!
> Jiangli
>> On Jun 11, 2018, at 1:37 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>> Please review this change to the implementation of CDS support to use
>> a new collector-based protocol for handling archived Java mirrors.
>> Rather than using the IN_ARCHIVE_ROOT feature of the Access API, we
>> instead use a new protocol provided by the collected heap (only
>> G1CollectedHeap for now, since only G1 supports this feature).  This
>> allows IN_ARCHIVE_ROOT to be removed from the Access API.
>> This changeset is based on work by Stefan Karlsson.
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8204585
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8204585/open.00/
>> Testing:
>> mach5 tier1,2,3, hs-tier4,5.
>> Local testing of hotspot_cds and hotspot_appcds.

More information about the hotspot-dev mailing list