RFR: 8204585: Remove IN_ARCHIVE_ROOT from Access API
kim.barrett at oracle.com
Tue Jun 12 14:46:51 UTC 2018
> On Jun 12, 2018, at 4:11 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> On Mon, 2018-06-11 at 18:58 -0400, Kim Barrett wrote:
>>> On Jun 11, 2018, at 6:26 PM, Jiangli Zhou <jiangli.zhou at oracle.com>
>>> Hi Kim,
>>> Both the changes and testing look good to me. Would it be better to
>>> rename MetaspaceShared::unarchive_heap_object() to
>>> MetaspaceShared::materialize_archived_object() to reflect the API
>>> in G1CollectedHeap? The use of ‘materialize’ in the GC API looks
>>> very good. Thank you for continuing improving the GC underlying
>> I like that suggestion. I’ll see what other folks think, but I’m
>> inclined to do it.
> looks good. Agree with the suggested name change.
Thanks. I’ll make the suggested name change.
More information about the hotspot-dev