RFR: 8204939: Change Access nomenclature: root to native

Kim Barrett kim.barrett at oracle.com
Wed Jun 13 09:05:50 UTC 2018

> On Jun 13, 2018, at 5:04 AM, Per Liden <per.liden at oracle.com> wrote:
> On 06/13/2018 10:49 AM, Kim Barrett wrote:
>> Please review this change of nomenclature in the Access API.  Rather
>> than using the word "root" we now use "native".  A "native" access has
>> an off-heap location, such as in a C/C++ data structure or global
>> variable.  This involves renaming the RootAccess class template to
>> NativeAccess, and renaming the IN_ROOT access decorator to IN_NATIVE.
>> Note that we are not renaming the IN_CONCURRENT_ROOT access decorator
>> as part of this change.  As discussed in JDK-8204690, we intend to
>> instead eliminate that decorator, as part of a later change.
>> This change consists of several sets of renamings and other minor
>> adjustments, all performed completely mechanically, e.g. by applying a
>> short sequence of bash commands to the repository being modified.  To
>> aid in reviewing, in addition to a webrev containing the full set of
>> changes, there is also a sequence of 4 webrevs that combined make up
>> that same complete set, along with the commands to produce them.
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8204939
> [...]
>> (5) All changes
>> http://cr.openjdk.java.net/~kbarrett/8204939/open.00/
> Looks good!
> /Per


>> Testing:
>> Local build and minimal testing of each of the partial webrevs.
>> Mach5 tier1,2,3 for the full change.

More information about the hotspot-dev mailing list