RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
volker.simonis at gmail.com
Fri Jun 15 09:01:08 UTC 2018
the change looks good. Could you please also update the comment in the
line above which still reads "STAT".
Also, maybe "STATI" would be a better name choice (longer is better :)
because the probability of a clash is lower (and it would nicely align
with QUEUE in the comments :) But I leave that up to you...
On Fri, Jun 15, 2018 at 9:47 AM, Baesken, Matthias
<matthias.baesken at sap.com> wrote:
> Please review this small change that fixes the AIX build after "8203641: Refactor String Deduplication into shared" .
> We are getting this compilation error :
> /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected.
> Looks like the name of the second template parameter (STAT)
> template <typename QUEUE, typename STAT>
> static void initialize_impl();
> is clashing with defines from the AIX system headers (where I find #define STAT 1 ) .
> Renaming STAT to something else fixes the build on AIX .
> Webrev :
> Bug :
> Thanks, Matthias
More information about the hotspot-dev