RFR (XS) 8204961: JVMTI jtreg tests build warnings on 32-bit platforms
boris.ulasevich at bell-sw.com
Mon Jun 18 09:24:12 UTC 2018
Thank you very much!
Yes, sponsor this please!
On 18.06.2018 07:54, David Holmes wrote:
> I ran this through our testing and it was fine.
> I can sponsor this for you if you like Boris.
> On 14/06/2018 10:55 PM, David Holmes wrote:
>> Hi Boris,
>> I added serviceability-dev as JVM TI and its tests are technically
>> serviceability concerns.
>> On 14/06/2018 10:39 PM, Boris Ulasevich wrote:
>>> Hi all,
>>> Please review the following patch:
>>> Recently opensourced JVMTI tests gives build warnings for ARM32 build.
>> I'm guessing the compiler version must have changed since we last ran
>> these tests on 32-bit ARM. :)
>>> GCC complains about conversion between 4-byte pointer to 8-byte jlong
>>> type which is Ok in this case. I propose to hide warning using
>>> conversion to intptr_t.
>> I was concerned about what the warnings might imply but now I see that
>> a JVM TI "tag" is simply a jlong used to funnel real pointers around
>> to use for the tagging. So on 32-bit the upper 32-bits of the tag will
>> always be zero and there is no data loss in any of the conversions.
>> So assuming none of the other compilers complain about this, this
>> seems fine to me.
More information about the hotspot-dev