RFR (M) JDK-8169559: Add class loader names to relevant VM messages

Lois Foltan lois.foltan at oracle.com
Fri Jun 22 23:29:37 UTC 2018

On 6/21/2018 4:37 PM, mandy chung wrote:
> Hi Lois,
> On 6/20/18 5:34 PM, Lois Foltan wrote:
>> Please review this change to introduce a new utility method 
>> Klass::class_in_module_of_loader() to uniformly provide a way to add 
>> a class' module name and class loader's name_and_id to error messages 
>> and potentially logging.
>> : open webrev at 
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8169559/webrev/
> Thanks for doing this.
> src/hotspot/share/classfile/moduleEntry.hpp
>    'M' is meant to be lower case in "unnamed Module", right?
> src/hotspot/share/interpreter/linkResolver.cpp
> +      "tried to access method %s.%s%s from class %s (%s%s%s)",
> Since you are on this file, it may read better if rephrased to:
>   "class %s tried to access method %s.%s%s (%s%s%s)",
Hi Mandy,
Thanks for the review.  All your comments have been addressed, see new 
webrev at:



> Thanks
> Mandy

More information about the hotspot-dev mailing list