RFR: 8205577: parallel/TestPrintGCDetailsVerbose.java fails assertion
kim.barrett at oracle.com
Thu Jun 28 04:29:26 UTC 2018
> On Jun 27, 2018, at 9:15 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> Wonderful analysis Kim!
> > http://cr.openjdk.java.net/~kbarrett/8205577/open.00/
> (old) L1694: (*p)->print_value_on(&ls);
> I agree with not printing, but you might want to leave a
> comment behind. Something like:
> // Do not try "(*p)->print_value_on()" here because it
> // is racy with parallel operations.
> Thumbs up in any case.
I thought about adding a comment, but one such comment seems odd; there are tons of
places where we shouldn’t do things like that.
More information about the hotspot-dev