RFR: 8198474: Move JNIHandles::resolve into jniHandles.inline.hpp

Kim Barrett kim.barrett at oracle.com
Thu Mar 1 19:48:10 UTC 2018

> On Mar 1, 2018, at 1:28 PM, Per Liden <per.liden at oracle.com> wrote:
> Hi,
> On 2018-03-01 00:46, Kim Barrett wrote:
>> Finally, updated webrevs:
>> full: http://cr.openjdk.java.net/~kbarrett/8198474/open.01/
>> incr: http://cr.openjdk.java.net/~kbarrett/8198474/open.01.inc/
> Looks good!


>> To remove the #include of jniHandles.inline.hpp by
>> jvmciCodeInstaller.hpp, I've moved the definitions referring to
>> JNIHandles::resolve from the .hpp file to the .cpp file.
>> For jvmciJavaClasses.hpp, I've left it including
>> jniHandles.inline.hpp. It already includes two other .inline.hpp
>> files.  I'm leaving it to whoever fixes the existing two to fix this
>> one as well.
> I'd love to see this fixed, but I realize it's non-trivial and would require quite a bit of work, so I'm ok with leaving this as is for now.

I think there are currently about 35 .hpp files that include .inline.hpp files.  And then there’s precompiled.hpp.
None that I’ve looked at looked “easy”.

More information about the hotspot-dev mailing list