RFR (tedious) 8173070: Remove ValueObj class for allocation subclassing for runtime code
thomas.schatzl at oracle.com
Thu Mar 8 19:21:21 UTC 2018
On Thu, 2018-03-08 at 19:47 +0100, Stefan Karlsson wrote:
> Looks good. The comment in allocation.hpp is a bit weird, but Coleen
> has promised that it goes away in subsequent patches.
there is also a comment referencing "ValueObj" in instanceKlass.hpp.
I think just removing "ValueObjs embedded in klass." would be fine.
I do not need to re-review for that change.
Thanks a ton btw - these VALUE_OBJ_CLASS_SPEC decorators also mess up
Oracle Studio code parsing (a bug) :)
> On 2018-03-08 19:26, coleen.phillimore at oracle.com wrote:
> > This change removes VALUE_OBJ_CLASS_SPEC as subclass for classes
> > in
> > the runtime code. I decided to split this into 3 parts to divide
> > the
> > clicking. See the bug for discussion of why we would like to
> > remove
> > this null class on most platforms in favor of the link time check
> > to
> > disallow Hotspot code from calling global operators new and delete
> > (bug https://bugs.openjdk.java.net/browse/JDK-8198243)
> > Tested with mach5 nightly tests with the full set of changes and
> > mach5
> > tier1-2 with this set.
> > open webrev at http://cr.openjdk.java.net/~coleenp/8173070.01/webre
> > v
> > bug link https://bugs.openjdk.java.net/browse/JDK-8173070
> > I'll update the copyrights with hg commit.
> > Thanks,
> > Coleen
More information about the hotspot-dev