RFR: 8199425: JTReg failure: runtime/stringtable/StringTableVerifyTest.java
david.holmes at oracle.com
Mon Mar 12 04:28:07 UTC 2018
Hi Coleen, Daniel,
On 11/03/2018 12:35 AM, coleen.phillimore at oracle.com wrote:
> Hi I didn't mean that you should push. I wanted you to do an hg commit
> and I would import the changeset and push for you. I don't see an
> openjdk author name for you. Have you signed the contributor agreement?
Coleen: Daniel is dstewart (Qualcomm Datacenter Technologies is the
Daniel: as Coleen indicated you can't do the hg push as you are not a
Committer, so just create the changeset using "hg commit" and ensure the
commit message has the correct format  e.g. from a previous change of
8196361: JTReg failure: serviceability/sa/ClhsdbInspect.java
Summary: Modified test search strings to those guaranteed to exist in
the passing cases.
Reviewed-by: dholmes, jgeorge
> On 3/9/18 11:23 PM, stewartd.qdt wrote:
>> I'd love to Coleen, but having never pushed before, I'm running into
>> issues. It seems I haven't figured out the magic set of steps yet. I
>> get that I am unable to lock jdk/hs as it is Read Only.
>> I'm off for the next Thursday. So, if it can wait until then, I'm
>> happy to keep trying to figure it out. If you'd like, you may go ahead
>> and take the webrev. It seems that is what others have done for other
>> patches I made. But either way I'll have to figure this out.
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
>> Behalf Of coleen.phillimore at oracle.com
>> Sent: Friday, March 9, 2018 7:55 PM
>> To: hotspot-dev at openjdk.java.net
>> Subject: Re: RFR: 8199425: JTReg failure:
>> Looks good. Thank you for fixing this.
>> Can you hg commit the patch with us as reviewers and I'll push it?
>> On 3/9/18 5:20 PM, stewartd.qdt wrote:
>>> Please review this webrev  which attempts to fix a test error in
>>> runtime/stringtable/StringTableVerifyTest.java. This test uses the
>>> flag -XX:+VerifyStringTableAtExit, which is a diagnostic option and
>>> requires the flag -XX:+UnlockDiagnosticVMOptions.
>>> This test currently fails our JTReg testing on an AArch64 machine.
>>> This patch simply adds the -XX:+UnlockDiagnosticVMOptions.
>>> The bug report is filed at .
>>> I am happy to modify the patch as necessary.
>>> Daniel Stewart
>>>  - http://cr.openjdk.java.net/~dstewart/8199425/webrev.01/
>>>  - https://bugs.openjdk.java.net/browse/JDK-8199425
More information about the hotspot-dev