8199696: Remove Runtime1::arraycopy

Erik Österlund erik.osterlund at oracle.com
Fri Mar 16 09:36:09 UTC 2018

Hi Martin,

Thanks for the review.
I removed the declaration in the header file as well as you said (with 
new webrev).

Full webrev:

Incremental webrev:


On 2018-03-15 18:16, Doerr, Martin wrote:
> Hi Erik,
> PPC64 and s390 parts look good.
> Arraycopy should get removed from c1_Runtime1.hpp, too.
> Best regards,
> Martin
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Erik Österlund
> Sent: Donnerstag, 15. März 2018 16:18
> To: hotspot-dev developers <hotspot-dev at openjdk.java.net>
> Subject: RFR: 8199696: Remove Runtime1::arraycopy
> Hi,
> The Runtime1::arraycopy stub appears to only be used on S390 because
> there is no StubRoutines::generic_arraycopy() provided. However, C1
> could then simply take a slow path and call its arraycopy stub that
> performs a native call. Then this logic may be removed.
> I added an assert on each platform that I think should have a
> generic_arraycopy() stub, and added a branch to the slow path on S390 if
> there is no such stub. If a stub is eventually added on S390, it should
> automatically pick that up.
> Webrev:
> http://cr.openjdk.java.net/~eosterlund/8199696/webrev.00/
> Bug ID:
> https://bugs.openjdk.java.net/browse/JDK-8199696
> Thanks,
> /Erik

More information about the hotspot-dev mailing list