RFR: 8199739: Use HeapAccess when loading oops from static fields in javaClasses.cpp

Roman Kennke rkennke at redhat.com
Fri Mar 16 15:10:05 UTC 2018

Am 16.03.2018 um 15:39 schrieb Stefan Karlsson:
> Hi all,
> Please review this patch to use HeapAccess<>::oop_load instead of
> oopDesc::load_decode_heap_oop when loading oops from static fields in
> javaClasses.cpp:
> http://cr.openjdk.java.net/~stefank/8199739/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8199739
> It's necessary to use HeapAccess<>::oop_load to inject load barriers for
> GCs that need them.
> Thanks,
> StefanK

The change looks good.

I haven't checked: are there any stores in there that also need to go
through HeapAccess?

Thanks, Roman

More information about the hotspot-dev mailing list