RFR (L, tedious) 8199809: Don't include frame.inline.hpp and other.inline.hpp from .hpp files

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 21 17:36:10 UTC 2018

Hi Coleen,

This looks good to me (minus the comments from others in this thread).

I wonder about the functions in the new vframe.inline.hpp file:

I thought vframeStreamCommon::fill_from_frame and friends were going to 
move a .cpp, and then we could get rid of even more .inline.hpp 
includes. Did you change your mind about that?


On 2018-03-21 01:08, coleen.phillimore at oracle.com wrote:
> Summary: Remove frame.inline.hpp,etc from header files and adjust 
> transitive includes.
> Tested with mach5 tier1 on Oracle platforms: linux-x64, solaris-sparc, 
> windows-x64.  Built with open-only sources using 
> --disable-precompiled-headers on linux-x64, built with zero (also 
> disable precompiled headers).  Roman built with aarch64, and have 
> request to build ppc, etc.  (Please test this patch!)
> Semi-interesting details:  moved SignatureHandlerGenerator constructor 
> to cpp file, moved interpreter_frame_stack_direction() to target 
> specific hpp files (even though they're all -1), pd_last_frame to 
> thread_<os_cpu>.cpp because there isn't a thread_<os_cpu>.inline.hpp 
> file, lastly moved InterpreterRuntime::LastFrameAccessor into 
> interpreterRuntime.cpp file, and a few other functions moved in shared 
> code.
> This is the last of this include file technical debt cleanup that I'm 
> going to do.  See bug for more information.
> open webrev at http://cr.openjdk.java.net/~coleenp/8199809.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8199809
> I'll update the copyrights when I commit.
> Thanks,
> Coleen

More information about the hotspot-dev mailing list