RFR: 8199736: Define WIN32_LEAN_AND_MEAN before including windows.h

Erik Joelsson erik.joelsson at oracle.com
Thu Mar 22 15:08:55 UTC 2018

We always set this define on the command line for jdk libraries. Not 
clear to me if this belongs better in the source or as a command line 


On 2018-03-22 07:34, Robin Westberg wrote:
> Hi all,
> Please review the following change that defines WIN32_LEAN_AND_MEAN [1] before including windows.h. This marginally improves build times, and makes it possible to include winsock2.h.
> Issue: https://bugs.openjdk.java.net/browse/JDK-8199736 <https://bugs.openjdk.java.net/browse/JDK-8199736>
> Webrev: http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8199736/webrev.00/>
> Testing: hs-tier1
> Best regards,
> Robin
> [1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745%28v=vs.85%29.aspx#faster_builds_with_smaller_header_files <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383745(v=vs.85).aspx#faster_builds_with_smaller_header_files>

More information about the hotspot-dev mailing list