RFR: 8200105: Remove cyclic dependency between oop.inline.hpp and collectedHeap.inline.hpp
stefan.karlsson at oracle.com
Thu Mar 22 18:23:53 UTC 2018
On 2018-03-22 19:05, coleen.phillimore at oracle.com wrote:
> This is cool how every include line is 2 characters less than the
> On 3/22/18 12:10 PM, Stefan Karlsson wrote:
>> Hi all,
>> Please review this patch to remove a cyclic dependency between
>> oop.inline.hpp and collectedHeap.inline.hpp:
>> The ground work for this cleanup had already been done with:
>> 8199728: Remove oopDesc::is_scavengable
>> What's done in this trivial patch is:
>> 1) Move some debug functions out from the collectedHeap.inline.hpp
>> and into collectedHeap.hpp.
> You mean into collectedHeap.cpp right?
Yes, of course. :)
>> 2) Removed collectedHeap.inline.hpp and fixed missing includes to
>> make it compile again.
> Looks good. Less transitive includes. I assume you ran open-only
> with --disable-precompiled-headers as well as the oracle platforms in
Yes. But everything is a moving target, so I'll rebuild again before
this is pushed.
> Zero build is probably unnecessary here (it builds now).
> I concur that this is trivial.
Thanks for the review!
More information about the hotspot-dev