RFR (XXS) 8183238 Obsolete CheckEndorsedAndExtDirs and remove checks for lib/endorsed and lib/ext

David Holmes david.holmes at oracle.com
Thu Mar 29 23:24:54 UTC 2018

On 30/03/2018 4:16 AM, Ioi Lam wrote:
> Hi Alan,
> Thanks for the reminder of the other files. I checked all the files in 
> the open and closed repos with 'grep -r CheckEndorsedAndExtDirs'. I 
> found only 3 man pages in the open repo that contained references to 
> CheckEndorsedAndExtDirs. No test cases or any other files refer to this 
> option.
> Here's an updated webrev that added the changes to the mage pages. It 
> also removes the dead code in arguments.cpppointed out by Mandy and David.
> http://cr.openjdk.java.net/~iklam/jdk11/8183238-obsolete-CheckEndorsedAndExtDirs.v02/ 

Seems okay, though I thought the man page sources were "dead" anyway. 
Surprised to still see them there.


> Thanks
> - Ioi
> On 3/28/18 12:11 AM, Alan Bateman wrote:
>> On 28/03/2018 00:46, Ioi Lam wrote:
>>> Hi please review this very small change:
>>> http://cr.openjdk.java.net/~iklam/jdk11/8183238-obsolete-CheckEndorsedAndExtDirs.v01/ 
>>> https://bugs.openjdk.java.net/browse/JDK-8183238
>>> The CheckEndorsedAndExtDirs flag has been deprecated since JDK 10 and
>>> all uses of it have been removed from the test cases.
>> This looks good. I assumed you've checked that we don't have any tests 
>> or man pages or other references to this option.
>> -Alan

More information about the hotspot-dev mailing list